Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some statistics #35

Merged
merged 1 commit into from
Nov 8, 2023
Merged

remove some statistics #35

merged 1 commit into from
Nov 8, 2023

Conversation

ArneBinder
Copy link
Owner

This PR removes TokenCountCollector, FieldLengthCollector, SubFieldLengthCollector, DummyCollector, LabelCountCollector because they were re-added to pytorch-ie, see ArneBinder/pytorch-ie#367. This also moves SpanLengthCollector into its own module.

…tCollector, FieldLengthCollector, SubFieldLengthCollector, DummyCollector, LabelCountCollector; move SpanLengthCollector into its own module
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #35 (b508ee9) into main (ae3dbec) will decrease coverage by 0.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   92.76%   92.51%   -0.26%     
==========================================
  Files          13       14       +1     
  Lines        1258     1202      -56     
==========================================
- Hits         1167     1112      -55     
+ Misses         91       90       -1     
Files Coverage Δ
src/pie_datasets/statistics/__init__.py 100.00% <100.00%> (ø)
...c/pie_datasets/statistics/span_length_collector.py 87.93% <ø> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@ArneBinder ArneBinder merged commit f2925d1 into main Nov 8, 2023
4 checks passed
@ArneBinder ArneBinder deleted the remove_some_statistics branch November 8, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant