Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate test workflow for datasets #117

Merged
merged 9 commits into from
Apr 15, 2024
Merged

Conversation

ArneBinder
Copy link
Owner

@ArneBinder ArneBinder commented Apr 15, 2024

This PR outsources tests to new test_datasets.yaml GitHub CI workflow. This is the first approach to handle #112.

The following items in the workflow configs are adjusted:

  • on.(push|pull_request).paths(-ignore): only execute the workflow if the respective files did change
  • add --ignore=tests/dataset_builders / tests/dataset_builders to pytest arguments: only execute the respective tests
  • set --cov=src / --cov: only calculate the coverage for the respective files
  • coverage.xml / coverage_datasets.xml to save and upload the coverage report

Notes:

  • this also adds new tests for the BratBuilder. Until now, this was covered by the Brat dataset tests, but since these are now separated, we also need explicit tests for the builder.
  • this also implements BratBuilder._generate_example() to make it "API-complete"

@ArneBinder ArneBinder added the ci Continuous Integration label Apr 15, 2024
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.42%. Comparing base (16410c9) to head (195642e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
- Coverage   95.47%   94.42%   -1.05%     
==========================================
  Files          23       23              
  Lines        1502     1507       +5     
==========================================
- Hits         1434     1423      -11     
- Misses         68       84      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArneBinder ArneBinder merged commit b1f4d92 into main Apr 15, 2024
5 checks passed
@ArneBinder ArneBinder deleted the separate_dataset_tests branch April 15, 2024 17:39
@ArneBinder ArneBinder changed the title separate test forkflow for datasets separate test workflow for datasets Apr 17, 2024
@ArneBinder ArneBinder linked an issue Apr 17, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

split CI test workflows into dataset_builders and other
1 participant