Update LoRaMAC Node submodule from version 4.5.1 to 4.6.0 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because why not? Use an updated version with possible version fixes. eeprom-board.c has been adapted to reflect the changed function return types.
|
@ThomasLeister thanks for this! How much testing have done with the updated version? |
|
I can confirm these changes work with the |
|
So far I have only tested the |
|
I'm facing some issues with ABP and these changes, so will hold off merging for now. If I revert to the current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because why not? ;-)
Use an updated version with possible version fixes.
eeprom-board.c has been adapted to reflect the changed function return
types.