Update egui to 0.26.2 and sdl2 to 0.36 #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Cohen <[email protected]>
Signed-off-by: David Cohen <[email protected]>
ArjunNair
reviewed
Mar 13, 2024
src/painter.rs
Outdated
| @@ -234,6 +47,30 @@ pub struct Painter { | |||
| pub screen_rect: Rect, | |||
| } | |||
|
|
|||
| macro_rules! get_error { | |||
There was a problem hiding this comment.
Might be better to name this macro as get_gl_error as that makes the intent even more clear.
There was a problem hiding this comment.
Thanks for reviewing. That makes sense. I've pushed a new commit renaming the macro
There was a problem hiding this comment.
I decided to rebase my pull request as I found an issue on how the shader sources were being propagated to outside the crate. The rebasing also addresses your previous comment.
Signed-off-by: David Cohen <[email protected]>
Signed-off-by: David Cohen <[email protected]>
egui sends vertices and indices ready to be sent to the shader. Reworking them is unnecessary and wastes CPU cycles each frame. Signed-off-by: David Cohen <[email protected]>
Signed-off-by: David Cohen <[email protected]>
Signed-off-by: David Cohen <[email protected]>
ArjunNair
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates egui dependency to 0.26.2 and sdl2 dependency to 0.36 and optimize misc parts of the code
Closes #37