Made class IdsMapCache thread-safe

Argent77 · Dec 27, 2015 · 1ad71e6 · 1ad71e6
1 parent a75fc2f
commit 1ad71e6
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 14 deletions.
diff --git a/src/infinity/NearInfinity.java b/src/infinity/NearInfinity.java
@@ -36,6 +36,7 @@
 import infinity.updater.Updater;
 import infinity.util.IdsMapCache;
 import infinity.util.StringResource;
+import infinity.util.Table2daCache;
 import infinity.util.io.FileLookup;
 import infinity.util.io.FileNI;
 
@@ -757,6 +758,7 @@ private static void clearCache()
   {
     FileLookup.getInstance().clearCache();
     IdsMapCache.clearCache();
+    Table2daCache.clearCache();
     SearchFrame.clearCache();
     StringResource.close();
     ProRef.clearCache();

diff --git a/src/infinity/util/IdsMapCache.java b/src/infinity/util/IdsMapCache.java
@@ -17,29 +17,36 @@ public final class IdsMapCache
 
   public static void cacheInvalid(ResourceEntry entry)
   {
-    common.remove(entry.toString().toUpperCase(Locale.ENGLISH));
+    if (entry != null) {
+      common.remove(entry.toString().toUpperCase(Locale.ENGLISH));
+    }
   }
 
   public static void clearCache()
   {
     common.clear();
   }
 
-  public static synchronized IdsMap get(String name) // name must be in UPPER CASE
+  public static synchronized IdsMap get(String name)
   {
-    IdsMap map = common.get(name);
-    if (map == null) {
-      ResourceEntry resEntry = ResourceFactory.getResourceEntry(name);
-      if (resEntry == null && name.equalsIgnoreCase("ATTSTYLE.IDS"))
-        resEntry = ResourceFactory.getResourceEntry("ATTSTYL.IDS");
-      if (resEntry == null)
-        System.err.println("Could not find " + name);
-      else {
-        map = new IdsMap(resEntry);
-        common.put(name, map);
+    IdsMap retVal = null;
+    if (name != null) {
+      name = name.trim().toUpperCase(Locale.ENGLISH);
+      retVal = common.get(name);
+      if (retVal == null) {
+        ResourceEntry resEntry = ResourceFactory.getResourceEntry(name);
+        if (resEntry == null && name.equals("ATTSTYLE.IDS")) {
+          resEntry = ResourceFactory.getResourceEntry("ATTSTYL.IDS");
+        }
+        if (resEntry == null) {
+          System.err.println("Could not find " + name);
+        } else {
+          retVal = new IdsMap(resEntry);
+          common.put(name, retVal);
+        }
       }
     }
-    return map;
+    return retVal;
   }
 
   private IdsMapCache(){}

diff --git a/src/infinity/util/Table2daCache.java b/src/infinity/util/Table2daCache.java
@@ -16,7 +16,9 @@ public class Table2daCache
   /** Removes the specified 2DA resource from the cache. */
   public static synchronized void cacheInvalid(ResourceEntry entry)
   {
-    map.remove(entry);
+    if (entry != null) {
+      map.remove(entry);
+    }
   }
 
   /** Removes all cached 2DA resources. */