Zoom slew rate #81
Merged
Zoom slew rate #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ryanf55 - can you update base to target Update done already, prior to review. |
srmainwaring
force-pushed
the
zoom-slew
branch
from
1193fd9
to
59869aa
Compare
srmainwaring
requested changes
Jan 25, 2024
|
I had to add a fix for if the user doesn't specify |
srmainwaring
force-pushed
the
zoom-slew
branch
from
f4701c7
to
a7a3dcf
Compare
* Implements slew rate for zooming configured in m/s Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Rhys Mainwaring <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
* Infinite rate would crash, now it has special handling Signed-off-by: Ryan Friedman <[email protected]>
srmainwaring
force-pushed
the
zoom-slew
branch
from
a7a3dcf
to
ae1beb6
Compare
srmainwaring
approved these changes
Jan 30, 2024
| if (this->impl->zoomChanged) { | ||
| // Only calculate goal once each time zoom is changed. | ||
| const auto requestedZoomCmd = this->impl->zoomCommand.load(); | ||
| const auto clampedZoomCmd = std::clamp(requestedZoomCmd, |
There was a problem hiding this comment.
Something is not quite right with the constraints. After zooming in I reset the zoom to the minimum factor using
gz topic -t "/model/gimbal/sensor/camera/zoom/cmd_zoom" -m gz.msgs.Double -p "data: 1.0"but there was no response. Using any value larger than 1.0 is working (e.g. 1.00000001).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Solves #57 , implementing a zoom slew rate to give realistic zoom effect for optical cameras like the Nikon P1000.
Usage
Add the following to your CameraZoomPlugin:
The value is camera-specific and can be calculated per the issue description.
Demo
zoom-plugin-demo.mp4
Dependencies
Depends on #79 to go in first.
Assumptions