-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using setup-gazebo
GitHub Action to install Gazebo in CI
#127
Conversation
@sauk2 thanks for the PR. Can you please squash and rebase your changes on |
bfb41c8
to
0719776
Compare
Signed-off-by: Saurabh Kamat <[email protected]>
0719776
to
dde315c
Compare
Sure, thanks for pointing it out! I have squashed all commits into one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is definitely an improvement and we should be able to apply the same change to some of out other repos that depend on Gazebo and ros_gz
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an excellent improvement. I checked through the action.yml file to see if there were any other options we could to set to speed up the CI, and didn't see any.
A little off-topic but you could look at increasing the scope of your workflow by spawning multiple jobs using a matrix in case you decide to support multiple Gazebo distributions on different ubuntu versions. |
Yep, we use matrix on some other repos to maintain multiple ROS distros. Are you interested in doing any more gazebo+CI+ROS related tasks for ArduPilot's Gazebo usage? We have a few you might be able to knock out that would be of great benefit to this project.
|
Sorry, I missed this comment. I would be happy to contribute more! Could I ask you to raise issues so we can discuss this more? |
Closes #126
Summary
This PR changes the CI to use the
setup-gazebo
GitHub Action to configure a Gazebo environment. It replaces Harmonic's installation steps and passes input to the action to take care of the installation.