-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Volz simulator, autotest for same #29040
Conversation
ea55695
to
5336270
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I read correctly that some timing changes needed to happen to support this?
Where they a change that needed to be done, or they were inherently caused by the new simmed servos?
If it's the former, wouldn't it be better they are a separate PR, to port more easily?
libraries/AP_HAL/SIMState.h
Outdated
@@ -99,8 +99,6 @@ class AP_HAL::SIMState { | |||
uint16_t _irlock_port; | |||
float _current; | |||
|
|||
bool _synthetic_clock_mode; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of doing away with the synthetic clock mode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not been removed - the option to enable it has gone away because it was always enabled anyway :-)
5336270
to
ea243fc
Compare
We've merged several PRs which fixed various things that came up. I've now rebased this PR on top of master, so this is really now just the commits related to the PR title. I hope. |
ea243fc
to
f048cde
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -122,6 +122,16 @@ float Aircraft::ground_height_difference() const | |||
return local_ground_level; | |||
} | |||
|
|||
float Aircraft::ambient_temperature_degC() const | |||
{ | |||
// FIXME: AP_Baro_SITL should be getting temperature from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker as it is in SITL, but shouldn't we just do this correctly now?
No description provided.