Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Volz simulator, autotest for same #29040

Merged
merged 6 commits into from
Jan 15, 2025

Conversation

peterbarker
Copy link
Contributor

No description provided.

Copy link
Contributor

@Georacer Georacer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I read correctly that some timing changes needed to happen to support this?
Where they a change that needed to be done, or they were inherently caused by the new simmed servos?

If it's the former, wouldn't it be better they are a separate PR, to port more easily?

@@ -99,8 +99,6 @@ class AP_HAL::SIMState {
uint16_t _irlock_port;
float _current;

bool _synthetic_clock_mode;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of doing away with the synthetic clock mode?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not been removed - the option to enable it has gone away because it was always enabled anyway :-)

@peterbarker
Copy link
Contributor Author

Do I read correctly that some timing changes needed to happen to support this? Where they a change that needed to be done, or they were inherently caused by the new simmed servos?

If it's the former, wouldn't it be better they are a separate PR, to port more easily?

We've merged several PRs which fixed various things that came up.

I've now rebased this PR on top of master, so this is really now just the commits related to the PR title. I hope.

Copy link
Contributor

@MattKear MattKear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -122,6 +122,16 @@ float Aircraft::ground_height_difference() const
return local_ground_level;
}

float Aircraft::ambient_temperature_degC() const
{
// FIXME: AP_Baro_SITL should be getting temperature from the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker as it is in SITL, but shouldn't we just do this correctly now?

@peterbarker peterbarker merged commit e7801c1 into ArduPilot:master Jan 15, 2025
99 checks passed
@peterbarker peterbarker deleted the pr/volz-simulator branch January 15, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants