-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation fixes when features disabled / feature extraction fixes #29007
Compilation fixes when features disabled / feature extraction fixes #29007
Conversation
Fails: ./Tools/autotest/test_build_options.py --no-disable-all --no-disable-none --no-disable-in-turn --board=CubeOrange --define-match-glob=AP_NETWORKING_CAN_MCAST_ENABLED
Thanks for this. I think the Copter changes are probably best answered by @andyp1per (who I see you've already tagged) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AP_INERTIALSENSOR_FAST_SAMPLE_WINDOW_ENABLED should never be built without harmonic notch support, so we should express the dependency a different way if necessary rather than littering the code with extra defines
…_WINDOW_ENABLED from sanity check the symbol supplied will only ever exist on Copter as it is nthe only thing that supports the window
…lane ... only ever compiled in on Plane
the default, "init" doesn't exist for this mode
"> AP_INERTIALSENSOR_FAST_SAMPLE_WINDOW_ENABLED should never be built without harmonic notch support, so we should express the dependency a different way if necessary rather than littering the code with extra defines"
1519d77
to
915929a
Compare
I was indeed wondering if that was the case. I've added the dependency into |
test_build_options.py
exemptions list (which should be moved intobuild_options.py
AP_NETWORKING_ENABLED
.