-
Notifications
You must be signed in to change notification settings - Fork 17.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools: stop requiring python-is-python3 package #28055
base: master
Are you sure you want to change the base?
Tools: stop requiring python-is-python3 package #28055
Conversation
If you uninstall this, you find that waf can't run.
It was the python team's recommendation to update shebangs if a script could run on python3, to say python3.
To me, the risk of impacting people is low because we already install ardupilot/Tools/environment_install/install-prereqs-ubuntu.sh Lines 85 to 89 in 33d75f1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't support py2 anymore (or not actively), so yes let's go into this direction !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we do this, we can also remove the # encoding: utf-8
line, that's only needed in python2 scripts.
OK, all good, full-steam ahead. |
First action seems to go request to the waf maintainer if they would be interested in following these recommendations: https://peps.python.org/pep-0394/#for-python-script-publishers |
What entry-point are you worried about? Have you checked to see if it has been updated upstream? We could probably also carry a trivial patch for it if required. |
I removed python-is-python3 and it errored out in the waf submodule when building, so that's why I thought to start there.
Yea, I checked upstream, it's still using
For sure! It should be easy to whip up. I'll give it a go unless you're bored. |
Please go ahead. See what happens if you PR upstream too? |
fb37d91
to
5470871
Compare
da575aa
to
8283479
Compare
@Ryanf55 I've created a trivial PR against our waf fork to use python3 and referenced it in here. I think past this we don't require I've left the environment install stuff alone, on the basis that without it you can't check out 4.5 and expect things to work without more hackery. Maybe in 4.7 we can get rid of those. |
No description provided.