Move parameter storage formatting up to AP_Vehicle #26181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I love the @peterbarker classics. Again removes more than it ads. Commit by commit, code duplication will die:) |
peterbarker
force-pushed
the
pr/parameter-clearing-up
branch
from
030dbd5
to
47b1456
Compare
tridge
approved these changes
Feb 12, 2024
peterbarker
force-pushed
the
pr/parameter-clearing-up
branch
from
47b1456
to
30c8a17
Compare
|
An issue related to this came up (see #26336) and in my testing it appears that increasing k_format_version does not lead to parameters being reset. I suspect that the issue was present before you moved the code to AP_Vehicle but I haven't confirmed this yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested in SITL; parameters are preserved going from master to this, and setting FORMAT_VERSION still erases parameters.
I've chosen this shape (vehicles call a method on the base class) as not all vehicles which inherit from AP_Vehicle actually have a k_format_version (e.g. Replay). These vehicles do their own thing, so we have to consider the format-version-checking an optional feature which AP_Vehicle can provide.