Fix Warning Repeat Time #3445
Merged
Fix Warning Repeat Time #3445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs to come after the speechEnable setting is loaded
The RepeatTime setting was also the worst-case detection time
meee1
approved these changes
Nov 12, 2024
EosBandi
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RepeatTime setting was also the worst-case detection time
As implemented, no matter what, the condition is checked every
RepeatTimeseconds. At the default time of 10, this means it could take up to 10s before the warning manager tells you that something bad happened. On average it takes 5.This fixes it so the last repeat time only gets recorded when the check returns true. So, after this function returns true, it will not check again for another
RepeatTimeseconds.Also a driveby fix of the initialization of the
_speechmember of the warning engine. It was always initializing to null due to being initialized before the user's speech settings were loaded.