make BLE device name and SSID the same #77
Conversation
RemoteIDModule/BLE_TX.cpp
Outdated
| snprintf(legacy_name, sizeof(legacy_name), "ArduRemoteID_%s", &UAS_ID[ID_len-ID_tail]); | ||
|
|
||
| //fall back options for BLE device name. If the uas_id is not set, use the 4 chars from the MAC address instead | ||
| if (strlen(g.uas_id) == 0) { |
There was a problem hiding this comment.
this needs this PR first:
#82
There was a problem hiding this comment.
okay, so leave this PR as is. Unless you want have additional feedback.
|
@BluemarkInnovations I've updated the PR and force pushed, but I'm really not sure this is a good idea. What if the user sets the same UAS_ID on two aircraft? We'd be able to see both now, but could not if we force the same BT ID. |
Not sure how the Android app works, but I assume it will show up as two devices. This week busy, but I can try to do some testing next week. I understand your point, but we are talking about a user that enters incorrect data i.e. is non-compliant. The downside of the current existing implementation is that the used SSID name has no relation with the UAS_ID settings. I mean if you detect multiple RID SSIDs, you don't know which one to connect to if you want to change the settings of drone with UAD_ID A. So to me this PR has more benefits than drawbacks. |
|
@tridge I have tested it with two db201 modules setting it to the same UAS ID settings. In the OpenDroneID app they are detected as two separate RID devices. |
and when you see then in WIFI tool for web status? They will show as the same |
In the PR, the advertisement BLE name and the WiFi SSID have the same format.