TUNIC: Make the standard entrances get made with tuples instead of sets #4546
+22
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
ScipioWright
changed the title
ScipioWright
added
the
is: refactor/cleanup
|
Tuple YES! Code LGTM. |
Jouramie
approved these changes
Jan 24, 2025
ScipioWright
added
waiting-on: core-review
Co-authored-by: Exempt-Medic <[email protected]>
Exempt-Medic
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
#4410 This has a test looking at entrance creation order, and it didn't take any time to do this change which I'm pretty sure solves their issue.
How was this tested?
Test gen. Didn't actually check if it fixed the issue, but it's an obvious culprit.