Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KDL3: Fix world access on non-strict open world #4543

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Silvris
Copy link
Collaborator

@Silvris Silvris commented Jan 23, 2025

What is this fixing or adding?

There's just been an entire set of rules missing since the initial merge of KDL3 that only causes an issue on a single settings combination. This creates unbeatable worlds by not accounting for logical requirements for stage completion, which would block access to the level's boss.

How was this tested?

Kirby's Dream Land 3:
    strict_bosses: "false"
    open_world: "true"
    ow_boss_requirement: 6

Watched the generated spheres no longer contain all 5 levels by sphere 5.

If this makes graphical changes, please attach screenshots.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jan 23, 2025
@NewSoupVi NewSoupVi added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. affects: release/blocker Issues/PRs that must be addressed before next official release. labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: release/blocker Issues/PRs that must be addressed before next official release. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants