Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factorio: Inventory Spill Traps #4457

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Factorio: Inventory Spill Traps #4457

wants to merge 3 commits into from
+59 −12

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

Inventory Spill Traps in Factorio

How was this tested?

factorio_sZ4HJUITDY

If this makes graphical changes, please attach screenshots.

factorio_sZ4HJUITDY

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jan 10, 2025
@Exempt-Medic Exempt-Medic added the is: enhancement Issues requesting new features or pull requests implementing new features. label Jan 10, 2025
@silasary
Copy link
Contributor

This is evil

qwint
qwint approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@qwint qwint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly reviewed the python but for my minimal lua experience that code looks good as well
pure code review, did not run any gens/tests/games/etc.

@Berserker66 Berserker66 added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boiscljo boiscljo boiscljo approved these changes

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

@qwint qwint qwint approved these changes

Assignees
No one assigned
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Berserker66 @silasary @qwint @Exempt-Medic @boiscljo