BizHawkClient: Add command to get size of memory domain #4439
+38
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
Zunawe
added
the
is: enhancement
beauxq
reviewed
Jan 7, 2025
| from . import MM2World | ||
|
|
||
| try: | ||
| if (await get_memory_size(ctx.bizhawk_ctx, "PRG ROM")) < 0x3FFB0: |
There was a problem hiding this comment.
get_memory_size says that it returns str
This would be comparing a str < int
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Adds a command that returns the size of the specified memory domain. If a client tries to read a large address, it's not guaranteed that that domain is at least that size for any arbitrary game on that system. For example, the Mega Man 2 client tries to read memory in Spelunker that doesn't exist while trying to identify the game.
@Silvris for the MM2 changes.
How was this tested?
Checked the size of ROM on an Emerald game. Did not test the MM2 changes.