Core: Crash less on loading settings with invalid apworlds #4438
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ke duplicate apworlds) note: i swear the issue was an importerror but i could only get attributeerrors on the getattr() call, maybe we want to check for both?
github-actions
bot
added
affects: core
qwint
changed the title
ScipioWright
added
the
is: bug/fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
handle nicer when a single world using settings api fails to load (like duplicate apworlds)
note: i swear the issue was an importerror but i could only get attributeerrors on the getattr() call, maybe we want to check for both?
How was this tested?
added an apworld that uses Settings to both custom_worlds and lib/worlds and saw it not crash on open host.yaml after the change
If this makes graphical changes, please attach screenshots.