Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS3: Update setup documentation #4437

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Jan 5, 2025

What is this fixing or adding?

This adds a link to the new map tracker and adds information on
troubleshooting common issues that have come up in the Discord.

This adds a link to the new map tracker and adds information on
troubleshooting common issues that have come up in the Discord.
@github-actions github-actions bot added is: documentation Improvements or additions to documentation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jan 5, 2025
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments/requests

worlds/dark_souls_3/docs/setup_en.md Outdated Show resolved Hide resolved
worlds/dark_souls_3/docs/setup_en.md Outdated Show resolved Hide resolved
worlds/dark_souls_3/docs/setup_en.md Outdated Show resolved Hide resolved
Comment on lines +108 to +109
* You own the DS3 DLC if your randomizer config has DLC enabled. (It's possible
but unconfirmed that you need the DLC even when it's disabled in your config).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really unconfirmed? I'm kinda surprised if nobody has done this recently?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know of any situations where we had someone positively say "I had DLC disabled in my config and buying it fixed the crash", and I really don't want to make it seem like a more likely fix than we're confident it is because it involves players spending real money.

Copy link
Member

@Exempt-Medic Exempt-Medic Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the parenthetical reads as "We're not sure if you need the DLC to play the game when you have them disabled" which sounds, idk, just like a bad thing to be unsure about?

worlds/dark_souls_3/docs/setup_en.md Outdated Show resolved Hide resolved
nex3 and others added 2 commits January 6, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: documentation Improvements or additions to documentation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants