Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFMQ: Fix collect_item #4433

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Exempt-Medic
Copy link
Member

What is this fixing or adding?

FFMQ's collect_item previously returned names (modified state) for non-progression items and did not handle remove properly. This fixes both of these things.

How was this tested?

This was tested using a fixed version of #2062 following Qwint's deepcopy comment. FFMQ failed the tests before these changes and succeeds after them.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jan 4, 2025
@Exempt-Medic Exempt-Medic added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. labels Jan 4, 2025
@Exempt-Medic
Copy link
Member Author

@Alchav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant