Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMZ3: Move non_local_items Changes Earlier #4424

Merged
merged 1 commit into from
Jan 20, 2025
Merged

SMZ3: Move non_local_items Changes Earlier #4424

merged 1 commit into from
Jan 20, 2025

Conversation

Exempt-Medic
Copy link
Member

What is this fixing or adding?

Moves the changes to non_local_items from create_items to generate_early. The primary motivation for this is a future PR requiring that local/non_local options not be changed after generate_early, which helps to cleanup some of the code in Main.py

How was this tested?

Local generations with items in non_local_items with and without Keysanity enabled to see that items were properly removed. Also just printing the frozenset in generate_early and create_items to see that they were identical with various random yamls

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jan 2, 2025
@Exempt-Medic Exempt-Medic added is: refactor/cleanup Improvements to code/output readability or organizization. waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. labels Jan 2, 2025
nicholassaylor
nicholassaylor approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not see anywhere that this value was modified between the two changes that would cause a difference in output. LGTM

@Exempt-Medic
Copy link
Member Author

@lordlou

@Exempt-Medic Exempt-Medic removed the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jan 14, 2025
@Exempt-Medic Exempt-Medic mentioned this pull request Jan 14, 2025
Open
2 tasks
lordlou
lordlou approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@lordlou lordlou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense, thanks!

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. labels Jan 17, 2025
@Exempt-Medic Exempt-Medic merged commit a2fbf85 into ArchipelagoMW:main Jan 20, 2025
16 checks passed
@Exempt-Medic Exempt-Medic deleted the smz3-locality-timing branch January 20, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lordlou lordlou lordlou approved these changes

@nicholassaylor nicholassaylor nicholassaylor approved these changes

@Berserker66 Berserker66 Berserker66 approved these changes

Assignees
No one assigned
Labels
is: refactor/cleanup Improvements to code/output readability or organizization. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Exempt-Medic @Berserker66 @nicholassaylor @lordlou