Core: Add connect_entrances world step/stage #4420
Open
+82
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
NewSoupVi
added
the
is: enhancement
|
I was gonna add this to The Witness as part of this PR, but unfortunately, my entrances currently need to be connected before this step because I add extra locations in |
BadMagic100
reviewed
Jan 2, 2025
BadMagic100
approved these changes
Jan 2, 2025
|
Got permission from @gaithern to change KH1, the simplest apworld that can easily use this, over to this system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a lot of history for this, but basically, for Item Plando (using the upcoming rewrite) and Generic Entrance Randomizer to work well together, there is a specific timing window that has to be satisfied. The easiest way to do this is to add a new
connect_entrancesworld stage.When entrance source/target regions have to be finalized is also currently undefined, which has lead to some minor debate. This should prevent this from being up for discussion in the future.