Options: support "random" and variations for OptionSet with defined valid_keys #4418
+58
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
qwint
reviewed
Jan 1, 2025
Comment on lines
+954
to
+956
| raise Exception( | ||
| f"{random_range[0]}-{random_range[1]} is outside allowed range " | ||
| f"0-{len(choice_list)} for option {self.__name__} for player {player_name}") |
There was a problem hiding this comment.
does it make more sense to just modify the chosen range instead of raising an exception because unlike normal random range the only way to find the "allowed range" is to hit this exception
Co-authored-by: qwint <[email protected]>
Exempt-Medic
reviewed
Jan 1, 2025
|
|
||
| def __init__(self, value: typing.Iterable[str]): | ||
| def __init__(self, value: typing.Iterable[str], random_str: str = None): |
Exempt-Medic
added
the
is: enhancement
|
Really makes me wish we found a way already to actually put location groups and item groups in valid_keys Pretty cool tho |
|
Oh, just realized something |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Adds support for
random,random-low,random-high,random-mid, andrandom-range-x-yto OptionSet. The behavior is defined as follows.randomis a random number of random itemsrandom-low,random-high, andrandom-midis a random number (weighted towards the argument) of random itemsrandom-range-x-yis a random number between x and y of random items. This also supportsrandom-range-lowand similar variants.Only OptionSets that define valid keys (and thus, could appear on WebHost) can utilize this behavior. No WebHost behavior has been changed for now. Item/LocationSets are supported.
How was this tested?
Manually by providing a number of possible values to several OptionSet options in core. No automated testing has been added.
If this makes graphical changes, please attach screenshots.