Stardew Valley: Refactor buildings to use content packs #4239
+763
−453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
agilbert1412
added
the
is: refactor/cleanup
Jouramie
force-pushed
the
StardewValley/buildings-to-content-packs
branch
from
981027b to
66ec922
Compare
Jouramie
added a commit
to agilbert1412/Archipelago
that referenced
this pull request
Dec 1, 2024
…e generic # Conflicts: # worlds/stardew_valley/content/game_content.py # Conflicts: # worlds/stardew_valley/data/artisan.py # worlds/stardew_valley/data/game_item.py # worlds/stardew_valley/data/harvest.py # worlds/stardew_valley/data/shop.py
…handle this usecase
… in more early spheres
Jouramie
force-pushed
the
StardewValley/buildings-to-content-packs
branch
from
32ba7ad to
61cfeb2
Compare
Jouramie
added a commit
to agilbert1412/Archipelago
that referenced
this pull request
Dec 9, 2024
Jouramie
added a commit
to agilbert1412/Archipelago
that referenced
this pull request
Dec 17, 2024
agilbert1412
suggested changes
Dec 17, 2024
agilbert1412
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
This rewrites the buildings and building progression feature to use the content packs and feature APIs introduced with the 6.x.x release. This will make it easier in the future to introduce new buildings, and is a step forward to the introduction of animals in content packs that will be necessary for the integration of the new SVE content.
This also adds a
Pet Bowlin the start inventory of all games, which is a stepping stone in supporting the Pet Bowl randomization.This PR also contain the changes from #3662 and #4085, which have been open for a long time now and not merged. Sadly, I could not implement this PR without those previous changes. I will close the other PRs if this is merged first.Not anymore, both were merged.There are also a bunch of improvement to test readability.
How was this tested?
Unit tests, and generated a few games with the different building settings to make sure animal related locations are correctly placed after the progressive buildings in the spoiler. Validated that the rules described by with our
explainare the same or similar to the previous rules for the blueprint locations.If this makes graphical changes, please attach screenshots.
N/A