Skip to content

Commit

Permalink
Stop checking for item.advancement
Browse files Browse the repository at this point in the history
The item pool is already sorted, so we already know item.advancement == False.
  • Loading branch information
Ars-Ignis committed Jan 23, 2025
1 parent 956d8f1 commit f891e93
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Fill.py
Original file line number Diff line number Diff line change
Expand Up @@ -1106,7 +1106,7 @@ def distribute_local_nonprogression(multiworld: MultiWorld,
# fill local filler on local excluded locations first
new_filler_itempool: typing.List[Item] = []
for item in filler_itempool:
if not item.advancement and item.name in multiworld.worlds[item.player].options.local_items.value:
if item.name in multiworld.worlds[item.player].options.local_items.value:
local_nonprogression_items.append(item)
else:
new_filler_itempool.append(item)
Expand All @@ -1116,7 +1116,7 @@ def distribute_local_nonprogression(multiworld: MultiWorld,
# then add local useful to remaining local items and fill in default locations
new_useful_itempool: typing.List[Item] = []
for item in useful_itempool:
if not item.advancement and item.name in multiworld.worlds[item.player].options.local_items.value:
if item.name in multiworld.worlds[item.player].options.local_items.value:
local_nonprogression_items.append(item)
else:
new_useful_itempool.append(item)
Expand Down

0 comments on commit f891e93

Please sign in to comment.