Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to using validated_property to specify properties for validation #80

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

tclose
Copy link
Contributor

@tclose tclose commented Sep 16, 2024

No description provided.

…d of all properties being implicitly validated
@tclose tclose changed the title Revert to using required_property to specify properties for validation Revert to using validated_property to specify properties for validation Sep 16, 2024
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.08%. Comparing base (5f8dd32) to head (a5166ed).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
fileformats/core/field.py 0.00% 1 Missing ⚠️
fileformats/core/fileset.py 94.73% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   92.14%   92.08%   -0.06%     
==========================================
  Files          45       45              
  Lines        5234     5233       -1     
  Branches      586      582       -4     
==========================================
- Hits         4823     4819       -4     
- Misses        307      310       +3     
  Partials      104      104              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tclose tclose merged commit 34a7013 into main Sep 16, 2024
9 checks passed
@tclose tclose deleted the required-property branch September 16, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant