Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework pipeline autodocs based on feedback #120 #129

Merged
merged 9 commits into from
Sep 19, 2022

Conversation

Prepultrue
Copy link
Contributor

For #120:

  • Remove license Mounted at
  • Add known issues link
  • Add simple display of input/output format
  • Add description field for parameters

Cleanup some pre-commit warnings on other areas of the codebase

  • Unused imports
  • Missing trailing LFs
  • Removing other trailing whitespace

Also includes changes from #88

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2022

Codecov Report

Merging #129 (92ed30f) into develop (4361561) will increase coverage by 0.12%.
The diff coverage is 46.87%.

@@             Coverage Diff             @@
##           develop     #129      +/-   ##
===========================================
+ Coverage    76.77%   76.89%   +0.12%     
===========================================
  Files           57       57              
  Lines         5830     5830              
  Branches      1256     1258       +2     
===========================================
+ Hits          4476     4483       +7     
+ Misses        1032     1025       -7     
  Partials       322      322              
Impacted Files Coverage Δ
arcana/cli/apply.py 93.02% <ø> (-0.16%) ⬇️
arcana/cli/dataset.py 87.50% <ø> (ø)
arcana/cli/derive.py 56.66% <ø> (-0.72%) ⬇️
arcana/core/deploy/build.py 71.32% <ø> (ø)
arcana/core/deploy/utils.py 64.49% <0.00%> (-0.26%) ⬇️
arcana/data/stores/medimage/xnat/cs.py 80.89% <ø> (-0.42%) ⬇️
arcana/deploy/medimage/xnat.py 81.90% <ø> (ø)
arcana/test/fixtures/common.py 89.85% <ø> (-0.29%) ⬇️
arcana/test/fixtures/core.py 100.00% <ø> (ø)
arcana/test/fixtures/docs.py 100.00% <ø> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Thomas G. Close <[email protected]>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add your name + email here if you would like to

@tclose
Copy link
Contributor

tclose commented Sep 6, 2022

Looks good, will merge when tests pass

@tclose
Copy link
Contributor

tclose commented Sep 6, 2022

@Prepultrue the docs build test is broken

@tclose tclose merged commit bb3ad95 into ArcanaFramework:develop Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants