-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup CI for major supported platforms #67
base: experimental
Are you sure you want to change the base?
Conversation
The build has been red for years anyway, so it's not as if it was providing any value.
da26298
to
a9b6b9b
Compare
@jbeich Would you have any advise on getting Aquaria to build on FreeBSD? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From FreeBSD CI log:
In file included from BBGE/Core.cpp:47: /usr/local/include/SDL2/SDL_syswm.h:66:10: fatal error: 'X11/Xlib.h' file not found #include <X11/Xlib.h> ^~~~~~~~~~~~
FindSDL2.cmake in Aquaria doesn't take into account SDL2 can have dependencies of its own e.g.,
$ pkg-config sdl2 --cflags
-I/usr/local/include/SDL2 -I/usr/local/include ...
FindSDL2.cmake in voxel-engine uses pkg-config
but discards -I/usr/local/include
in order to export singular SDL2_INCLUDE_DIR
. :(
Downstream is not affected because it forces system libraries. -DAQUARIA_INTERNAL_PNG=OFF
and -DAQUARIA_INTERNAL_FTGL=OFF
do add -I/usr/local/include
.
@jbeich Thanks a lot for the tips! FreeBSD builds in CI are now green 💜 I'll have a look at building with Ninja and see whether that speed things up and such |
Many thanks to Jan Beich for the tip :)
Thanks, that's useful to know!
Yeah, the usability/reduced-magic advantages are definitely a big part of why I went with Cirrus, though it helps that it's AFAIK the only provider which supports all platforms Aquaria runs on, out of the box. |
Additional things to do:
Matrix build with/without GLM