New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Reblog: Respect user community sort order #1630

Open

marcustyphoon wants to merge 1 commit into AprilSylph:master from marcustyphoon:communities-order

Collaborator

marcustyphoon commented Oct 2, 2024 •

edited

Loading

Description

Really feels like indexOf would default to undefined instead of -1 if implemented today, don't you think?

Testing steps

Join multiple communities.
Confirm that Quick Reblog lists communities in the same order in which they appear in the Tumblr sidebar.
Change the order of the communities in the Tumblr sidebar.
Refresh the page.
Confirm that Quick Reblog lists communities in the same order in which they appear in the Tumblr sidebar.

Edit an error into the JSON.parse block. Confirm that Quick Reblog still works, listing communities in the default (alphabetocal by name) order.
Edit communitiesOrder to only contain a subset of your communities. Confirm that Quick Reblog still works, listing included communities in order, followed by the rest.


respect user community sort order

14d6094

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment