Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page title not being updated when navigating #1614

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

marcustyphoon
Copy link
Collaborator

I thought I remember instances in which the React code modified the title element rather than replacing it (and why wouldn't it, after all, if that's the minimal DOM diff). That being said...

Originally posted by @marcustyphoon in #1360 (comment)

Yeah, I don't know why I ever believed we wouldn't have to handle that case.

Description

When navigating from one tagged page to another, with our "Hide the Home/Following unread count" tweak enabled, the page title is not updated due to limitations in the code that detects the page title changing.

This fixes this by observing changes to the title element as well as its replacement, as my original code did.

Resolves #1613.

Testing steps

  • Enable the "Hide the Home/Following unread count" tweak
  • Navigate to a tagged page
  • Navigate to another tagged page by clicking on a tag or clicking a Tag Tracking+ sidebar item
  • Confirm that the page title corresponds with the current page (and does not include an unread count)

@marcustyphoon marcustyphoon added the bugfix Restores intended behavior label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Restores intended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag Tracking+: Tab/window title is not updated when switching tracked tag within same tab
1 participant