Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag Tracking+: Tab/window title is not updated when switching tracked tag within same tab #1613

Open
arcanetrivia opened this issue Sep 11, 2024 · 3 comments · May be fixed by #1614
Open

Tag Tracking+: Tab/window title is not updated when switching tracked tag within same tab #1613

arcanetrivia opened this issue Sep 11, 2024 · 3 comments · May be fixed by #1614
Assignees
@marcustyphoon
Labels
bug Something isn't working

Comments

@arcanetrivia
Copy link

Platform

Windows 10

Browser

Firefox 130.0

Addon version

1.0.3

Details

If I left-click on a tracked tag to continue re-using the same tab as I am already in (rather than middle-click to open in new tab), the tab/window title does not update to reflect the tag that I am currently viewing:

image

It looks like when I navigate in this way, it is doing some kind of "hot swap" of the page content without fully reloading the page. (Is that "soft navigation"? #933) If I open the tracked tag in a new tab, the title is as expected (after all, it's loading a page from scratch in that case).

This is a really minor issue, but can make it difficult to find a particular tab again if I click away from it. "I was sure I was looking at #david tennant; where the heck did that tab go?" well, it's the one reading "campbell bain".
@arcanetrivia arcanetrivia added the bug Something isn't working label Sep 11, 2024
@marcustyphoon
Copy link
Collaborator

Ooh, yep, that's probably a Tumblr bug with the tools they're exposing for extensions to use for stuff like navigation.

@marcustyphoon
Copy link
Collaborator

Actually, wait, no, this is a Tumblr bug in general! If I go to a tagged page and click a tag on a post, I'll go to another tagged page but the tab title won't update. Let's send this in to https://www.tumblr.com/support!

@marcustyphoon marcustyphoon added the wontfix This will not be worked on label Sep 11, 2024
@marcustyphoon
Copy link
Collaborator

Nope, crap, I was wrong about that, sorry. This one is our fault actually :D

@marcustyphoon marcustyphoon removed the wontfix This will not be worked on label Sep 11, 2024
@marcustyphoon marcustyphoon self-assigned this Sep 11, 2024
@marcustyphoon marcustyphoon linked a pull request Sep 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcustyphoon marcustyphoon

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix page title not being updated when navigating marcustyphoon/XKit-Rewritten
2 participants
@marcustyphoon @arcanetrivia