Two proposed corrections to text #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for a great book! Just spotted these possible errors.... Happy to provide more if I spot them, and they are welcome as part of the books errata ? Suggested corrections are: ### Page 130, Section 8.1 **Warnings are errors** it is very bad practice to ship code that ~~does not~~ compiles with warnings. Warnings are emitted for a reason. Source code should always compile without any errors or warnings before it is shipped. **Reason for suggested change:** the logic of the statement in the book is backwards. I assume it is meant to say that any code should not be shipped unless it has had corrections applied first, so any compile time warnings are fixed and therefore removed. As well as the correction, I have added an additional sentence to reinforce the point, if that is what is meant? ### Page 133, Section 8.2 **Static typing** means that all types are known ~~in~~ at compile time. There can be ~~absolutely incertitude~~ absolute certainty about data types. **Reason for suggested change:** Should read 'at compile time' not 'in compile time'. So at the point of compilation the types should all be defined and known. Use of '_absolutely incertitude_' is not what is meant here? It should state that static typing provides 'absolute certainty' as the static (ie unmovable) types are defined and therefore fixed in the source code, providing 'absolute certainty' of their purpose. Hope that's right :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for a great book! Just spotted these possible errors.... Happy to provide more if I spot them, and they are welcome as part of the books errata ?
Suggested corrections are:
Page 130, Section 8.1
Warnings are errors it is very bad practice to ship code that
does notcompiles with warnings. Warnings are emitted for a reason. Source code should always compile without any errors or warnings before it is shipped.Reason for suggested change: the logic of the statement in the book is backwards. I assume it is meant to say that any code should not be shipped unless it has had corrections applied first, so any compile time warnings are fixed and therefore removed. As well as the correction, I have added an additional sentence to reinforce the point, if that is what is meant?
Page 133, Section 8.2
Static typing means that all types are known
inat compile time. There can beabsolutely incertitudeabsolute certainty about data types.Reason for suggested change: Should read 'at compile time' not 'in compile time'. So at the point of compilation the types should all be defined and known. Use of 'absolutely incertitude' is not what is meant here? It should state that static typing provides 'absolute certainty' as the static (ie unmovable) types are defined and therefore fixed in the source code, providing 'absolute certainty' of their purpose. Hope that's right :)