-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support {bslib} in Rhino #596
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #596 +/- ##
==========================================
- Coverage 20.65% 20.29% -0.36%
==========================================
Files 9 9
Lines 460 468 +8
==========================================
Hits 95 95
- Misses 365 373 +8 ☔ View full report in Codecov by Sentry. |
365ac37
to
c01851e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good! I haven't read the vignette, though (sick leave got me 😖) - I'll leave that to @jakubnowicki
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done. Please resolve my comments regarding the guide. Also, please check the discussion in the design doc. I'm ok with merging the PR as is, but I would love to hear your thoughts.
Changes
Closes #595. Implements the changes proposed in Design Doc: {bslib} in Rhino:
sass: custom
configuration option and handle it inbuild_sass()
.rhino.yml
, changelog).