Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support {bslib} in Rhino #596

Merged
merged 7 commits into from
Jul 1, 2024
Merged

Support {bslib} in Rhino #596

merged 7 commits into from
Jul 1, 2024

Conversation

kamilzyla
Copy link
Collaborator

Changes

Closes #595. Implements the changes proposed in Design Doc: {bslib} in Rhino:

  1. Add sass: custom configuration option and handle it in build_sass().
  2. Attach favicon and minified files only if they exist (check each time the app is reloaded).
  3. Update documentation (how-to, rhino.yml, changelog).

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 10 lines in your changes missing coverage. Please review.

Project coverage is 20.29%. Comparing base (07f2f56) to head (1f061c3).

Current head 1f061c3 differs from pull request most recent head 565ef98

Please upload reports for the commit 565ef98 to get more accurate results.

Files Patch % Lines
R/app.R 57.14% 6 Missing ⚠️
R/tools.R 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
- Coverage   20.65%   20.29%   -0.36%     
==========================================
  Files           9        9              
  Lines         460      468       +8     
==========================================
  Hits           95       95              
- Misses        365      373       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kamilzyla kamilzyla force-pushed the 595-support-bslib branch from 365ac37 to c01851e Compare June 25, 2024 13:40
@kamilzyla kamilzyla changed the title 595 support bslib Support {bslib} in Rhino Jun 25, 2024
Copy link
Contributor

@TymekDev TymekDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! I haven't read the vignette, though (sick leave got me 😖) - I'll leave that to @jakubnowicki

Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. Please resolve my comments regarding the guide. Also, please check the discussion in the design doc. I'm ok with merging the PR as is, but I would love to hear your thoughts.

vignettes/explanation/rhino-yml.Rmd Outdated Show resolved Hide resolved
vignettes/how-to/use-bslib.Rmd Outdated Show resolved Hide resolved
vignettes/how-to/use-bslib.Rmd Outdated Show resolved Hide resolved
vignettes/how-to/use-bslib.Rmd Show resolved Hide resolved
vignettes/how-to/use-bslib.Rmd Outdated Show resolved Hide resolved
@kamilzyla kamilzyla merged commit aad552a into main Jul 1, 2024
10 checks passed
@kamilzyla kamilzyla deleted the 595-support-bslib branch July 1, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure {bslib} can be used with Rhino
4 participants