-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for shiny.autoreload
#559
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #559 +/- ##
==========================================
- Coverage 29.31% 28.57% -0.75%
==========================================
Files 10 10
Lines 481 511 +30
==========================================
+ Hits 141 146 +5
- Misses 340 365 +25 ☔ View full report in Codecov by Sentry. |
d714c7f
to
d541f9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine, but I would love to hear the opinion from @TymekDev , as he did more research on autoreloading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Clean changes and well documented.
I was about to suggest a mention about shiny::devmode
for enabling autoreload, but I see it is marked as an experimental (for a couple of years now), so it's up to you if you include it in the vignette.
d541f9c
to
976b8b9
Compare
Changes
Supersedes PR #528, addresses issues #339, #552. Add support for automatic reloading with
options(shiny.autoreload = TRUE)
.How to test
Set
options(shiny.autoreload = TRUE)
and run a Rhino app. Modify e.g.main.R
- the app should automatically reload and show the changes. It should work with all settings oflegacy_entrypoint
with the exclusion ofapp_dir
.