Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for shiny.autoreload #559

Merged
merged 4 commits into from
Feb 20, 2024
Merged

Add support for shiny.autoreload #559

merged 4 commits into from
Feb 20, 2024

Conversation

kamilzyla
Copy link
Collaborator

@kamilzyla kamilzyla commented Feb 15, 2024

Changes

Supersedes PR #528, addresses issues #339, #552. Add support for automatic reloading with options(shiny.autoreload = TRUE).

How to test

Set options(shiny.autoreload = TRUE) and run a Rhino app. Modify e.g. main.R - the app should automatically reload and show the changes. It should work with all settings of legacy_entrypoint with the exclusion of app_dir.

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (84bc815) 29.31% compared to head (6d7a914) 28.57%.

❗ Current head 6d7a914 differs from pull request most recent head 976b8b9. Consider uploading reports for the commit 976b8b9 to get more accurate results

Files Patch % Lines
R/app.R 14.70% 29 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
- Coverage   29.31%   28.57%   -0.75%     
==========================================
  Files          10       10              
  Lines         481      511      +30     
==========================================
+ Hits          141      146       +5     
- Misses        340      365      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from lazy-refactor to main February 16, 2024 13:46
Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, but I would love to hear the opinion from @TymekDev , as he did more research on autoreloading.

R/app.R Show resolved Hide resolved
Copy link
Contributor

@TymekDev TymekDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Clean changes and well documented.

I was about to suggest a mention about shiny::devmode for enabling autoreload, but I see it is marked as an experimental (for a couple of years now), so it's up to you if you include it in the vignette.

@kamilzyla kamilzyla merged commit db8e2f8 into main Feb 20, 2024
20 checks passed
@kamilzyla kamilzyla deleted the autoreload branch February 20, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants