Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sparse checkout in E2E workflow #545

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Use sparse checkout in E2E workflow #545

merged 1 commit into from
Jan 16, 2024

Conversation

kamilzyla
Copy link
Collaborator

Changes

Use actions/checkout@v4 with sparse-checkout instead of Bhacaz/checkout-files@v2, which is not very popular and doesn't seem to work on PRs originating from external repositories (problem encountered on #496).

How to test

If the E2E workflow still passes, we should be good.

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a5da6c5) 17.82% compared to head (4ccc481) 17.82%.

❗ Current head 4ccc481 differs from pull request most recent head 7be491c. Consider uploading reports for the commit 7be491c to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #545   +/-   ##
=======================================
  Coverage   17.82%   17.82%           
=======================================
  Files           9        9           
  Lines         404      404           
=======================================
  Hits           72       72           
  Misses        332      332           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kamilzyla kamilzyla force-pushed the e2e-sparse-checkout branch from d7f206a to 7be491c Compare January 15, 2024 12:21
@jakubnowicki
Copy link
Member

@kamilzyla the CI fails for Ubuntu - oldrel, PTAL.

@kamilzyla
Copy link
Collaborator Author

@jakubnowicki Our E2E tests are flaky - Cypress times out occasionally. Passed on 3rd attempt.

@jakubnowicki
Copy link
Member

@jakubnowicki Our E2E tests are flaky - Cypress times out occasionally. Passed on 3rd attempt.

Can we do anything about that? Please at least add an issue.

Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kamilzyla
Copy link
Collaborator Author

I'm confident we can do something about it, but I think it needs a deeper investigation. Issue created here: #546.

@kamilzyla kamilzyla merged commit 9631c74 into main Jan 16, 2024
20 checks passed
@kamilzyla kamilzyla deleted the e2e-sparse-checkout branch January 16, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants