Cran compliance

[radbasa]

Have you read the Contributing Guidelines?

Address CRAN comments on package submission.

Description

Clear and concise description of what changed and why.
If necessary, include screenshots and/or a step-by-step guide on how to test the changes.

Definition of Done

• The change is thoroughly documented.
• The CI passes (R CMD check, linter, unit tests, spelling).
• Any generated files have been updated (e.g. .Rd files with roxygen2::roxygenise())

[radbasa]

box.lsp/tests/testthat/helper-utils.R

Lines 19 to 44 in 39ddad5

	language_client <- function(working_dir = getwd(), diagnostics = FALSE, capabilities = NULL) {
	withr::local_dir(working_dir)
	withr::local_file(".Rprofile", {
	if (testthat::is_checking()) {
	parser_code <- c(
	"box_use_parser <-",
	deparse(box.lsp::box_use_parser)
	)
	rprofile <- readLines(fs::path_package("box.lsp", "Rprofile.R"))
	} else {
	source(fs::path(rprojroot::find_package_root_file(), "R", "box_lsp.R"), local = TRUE)
	parser_code <- c(
	"box_use_parser <-",
	deparse(box_use_parser)
	)
	rprofile <- readLines(fs::path(rprojroot::find_package_root_file(), "inst", "Rprofile.R"))
	rprofile <- sub("box.lsp::", "", rprofile)
	}
	write(parser_code, ".Rprofile", append = TRUE)
	write(rprofile, ".Rprofile", append = TRUE)
	readLines(".Rprofile")
	})

CRAN might be flagging this because we are writing .Rprofile to getwd(). We need our custom .Rprofile in the working directory for the language server to use our custom box parser in

box.lsp/tests/testthat/helper-utils.R

Line 65 in 39ddad5

client$start(working_dir = working_dir, capabilities = capabilities)

[jakubnowicki]

I wouldn't set this as an error. Info + early return?

[jakubnowicki]

I feel being more specific with the action would be better for the UX. In case when .Rprofile exists, you could ask for modification and mention, that the lines will be added and the original part will be preserved. And in the case when there is no Rprofile, that it will be created.

[radbasa]

Would 1 note be an issue?