-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade action to NodeJS v20 #58
base: master
Are you sure you want to change the base?
Conversation
Hi @orj, can you check out this PR? |
Are there any updates on this PR? Thank you for your work! 😊 |
When this is going to be merged? |
GitHub announced that they will enforce node20 instead of a warning on 13th May |
Any updates on this PR getting merged? |
You can use this fork until this gets merged: |
@orj any news about this PR? |
@jozefizso's fork is working perfectly In the meantime, it can be integrated with Ty dude :) |
Just to be clear I mention that this PR has not moved in 5 months and using @XaviTorello suggestion until it does. Why is this taking so long is this project dead? |
Hi @orj , I hope you are doing well. I'm checking if you could review this PR so others can enjoy the |
Thanks for your patience here. I was added as a maintainer to help with the node 16 upgrade, but I neglected to hit 'watch' on the repo so I wasn't getting any notifications. I also wasn't using my GitHub hobby projects much so I didn't see the deprecation warning until recently. Node is now upgraded to 20 with #64 and I added a |
I originally checked out this pr before making #64 but decided to make mine because just changing to node20 would possibly make the review faster. These upgrades seem fine after testing it locally and inside my github action since its just upgrades of devDependencies. |
Thanks for the update! It would be great to also update the |
It's done, please use |
Great work @ssrobins It would be super to also update |
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.20 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse)
The `@zeit/ncc` package is no longer maintained.
Hi @ssrobins, thanks for looking at this PR. I have rebased it on the |
Fixes #57
Fixes #56