Skip to content
This repository has been archived by the owner on Mar 26, 2019. It is now read-only.

Used Polly as execution engine for HTTP calls #28

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

gickis
Copy link

@gickis gickis commented Mar 8, 2018

The issue or feature being addressed

  • issue #27

Details on the issue fix or feature implementation

  • Used Polly as execution engine for HTTP calls

Confirm the following

  • I have ensured that I have merged the latest changes from the dev branch
  • I have successfully run a local build
  • I have included unit tests for the issue/feature
  • I have included the github issue number in my commits

@alhardy
Copy link
Collaborator

alhardy commented Mar 8, 2018

As mentioned here not sure I want to take the dependency.

Does the benefit outweigh taking on the dependency i.e. worth users of App Metrics dealing with potential version conflicts in their apps?

What are the benefits in using Polly versus a very simple implementation?

@gickis
Copy link
Author

gickis commented Mar 9, 2018

I know that Polly it's additional dependency to project, but on other hand using 3rd party frameworks will give us ability to concentrate on business logic instead of infrastructure things like "retry with backoff".

I even think that adding Polly will show to developers that App.Metrics is "Powered by Polly" and as result it could be positive indicator to App.Metrics project!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants