-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix S3246 warning #2204
Fix S3246 warning #2204
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2204 +/- ##
==========================================
+ Coverage 83.88% 83.90% +0.02%
==========================================
Files 313 313
Lines 7172 7172
Branches 1060 1060
==========================================
+ Hits 6016 6018 +2
+ Misses 785 784 -1
+ Partials 371 370 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -31,7 +31,7 @@ public interface ICircuitBreakerPolicy : IsPolicy | |||
/// Defines properties and methods common to all circuit-breaker policies generic-typed for executions returning results of type <typeparamref name="TResult"/>. | |||
/// </summary> | |||
/// <typeparam name="TResult">The type of the result.</typeparam> | |||
public interface ICircuitBreakerPolicy<TResult> : ICircuitBreakerPolicy | |||
public interface ICircuitBreakerPolicy<out TResult> : ICircuitBreakerPolicy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to have to read up on whether these changes are considered breaking or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The third reply under this Stack Overflow answer by Eric Lippert seems to suggest it's a breaking change: https://stackoverflow.com/a/3603459
Pull Request
The issue or feature being addressed
#1290
Details on the issue fix or feature implementation
Confirm the following
Not entirely sure, but in/out doesn’t seem to affect the API