Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S3246 warning #2204

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Conversation

Zombach
Copy link
Contributor

@Zombach Zombach commented Jul 17, 2024

Pull Request

The issue or feature being addressed

#1290

Details on the issue fix or feature implementation

  • Suppress S3246 in the code or fix the warning

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build
image I did not make any changes to the PublicAPI.Shipped file.

Not entirely sure, but in/out doesn’t seem to affect the API

@Zombach Zombach changed the title fix S3246 warning Fix S3246 warning Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.90%. Comparing base (f3bad33) to head (5ee86cf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2204      +/-   ##
==========================================
+ Coverage   83.88%   83.90%   +0.02%     
==========================================
  Files         313      313              
  Lines        7172     7172              
  Branches     1060     1060              
==========================================
+ Hits         6016     6018       +2     
+ Misses        785      784       -1     
+ Partials      371      370       -1     
Flag Coverage Δ
linux 83.90% <ø> (+0.02%) ⬆️
macos 83.88% <ø> (ø)
windows 83.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -31,7 +31,7 @@ public interface ICircuitBreakerPolicy : IsPolicy
/// Defines properties and methods common to all circuit-breaker policies generic-typed for executions returning results of type <typeparamref name="TResult"/>.
/// </summary>
/// <typeparam name="TResult">The type of the result.</typeparam>
public interface ICircuitBreakerPolicy<TResult> : ICircuitBreakerPolicy
public interface ICircuitBreakerPolicy<out TResult> : ICircuitBreakerPolicy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to have to read up on whether these changes are considered breaking or not.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The third reply under this Stack Overflow answer by Eric Lippert seems to suggest it's a breaking change: https://stackoverflow.com/a/3603459

@martincostello martincostello enabled auto-merge (squash) July 18, 2024 07:29
@martincostello martincostello mentioned this pull request Jul 18, 2024
5 tasks
@martincostello martincostello merged commit d72f72d into App-vNext:main Jul 18, 2024
15 checks passed
@Zombach Zombach deleted the zombach/remove-warning-s3246 branch July 18, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants