-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v8 docs #1599
Release v8 docs #1599
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1599 +/- ##
=======================================
Coverage 84.63% 84.63%
=======================================
Files 306 306
Lines 6819 6819
Branches 1045 1045
=======================================
Hits 5771 5771
Misses 839 839
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c10e424
to
fb05338
Compare
@martintmk This just needs the merge conflicts resolving and then I think this is ready to merge and then we're done, right? |
Do you think we should merge this even before v8.0.0 is released? |
8048cd8
to
a00b8f4
Compare
Yes because the README is embedded in the NuGet packages and it should be the v8 one, not the v7 one. Also there's going to be not much lag between merging this and shipping (hopefully), plus it's nicer (IMHO) for the Git tag for 8.0.0 to contain the matching documentation. |
Ok, making this ready for review. v7 users will still have not pointing to older documentation on the top. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just spotted this one typo.
Update the NuGet package README to point to polldocs.org.
I just realised that the NuGet package actually has its own README file to fix rendering issues in NuGet for the gallery's Content Security Policy. I've updated it to point to pollydocs.org instead of the wiki. |
Details on the issue fix or feature implementation
Closes #1091
Closes #1054
Confirm the following