-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration guide from v7 to v8 #1598
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1598 +/- ##
=======================================
Coverage 83.99% 83.99%
=======================================
Files 280 280
Lines 6548 6548
Branches 1020 1020
=======================================
Hits 5500 5500
Misses 839 839
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the changes mostly, but I can see some of the migrations being harder to navigate with so many options and nothing particularly matching one option to another.
|
||
<!-- snippet: migration-policy-wrap-v8 --> | ||
```cs | ||
// The "PolicyWrap" is integrated directly. Strategies are executed in the same order as they were added: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is exactly the comment I think is the best for understanding the changes. If I just look at the code sample, it's enough to understand what has changed from it directly and easily.
Details on the issue fix or feature implementation
Migration guide from v7 to v8
Contributes to #1091
Confirm the following