generated from ApeWorX/project-template
-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds Web3SubscriptionsManager.get_subscription_data_nowait() #95
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
de6fcee
feat: adds Web3SubscriptionsManager.pop_subscription_data()
mikeshultz 5c0a126
feat: adds get_subscription_data_nowait() to Web3SubscriptionsManager
mikeshultz 8845be4
fix: awaiting sync func
mikeshultz c587f8b
refactor: leverage asyncio.timeout when calling websocket client.recv
mikeshultz 762aa27
fix: one day I'll learn to lint before committing.
mikeshultz b810a95
fix: Python 3.10 does not support asyncio.timeout
mikeshultz 3edd89d
fix: get asyncio lock when calling _receive()
mikeshultz bd4f357
chore: cleanup, remove pop_subscription_data()
mikeshultz 0fb254a
chore: logging and return from generator on end
mikeshultz 59f9250
chore: cleanup debug statements
mikeshultz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the location where node websockets end up raising after getting randomly dropped?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it, according to the trace on #84
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, we might want to come back later and handle this timeout by reconnecting