feat: implement cchecksum for ~2x faster checksumming #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
changed the title
antazoey
changed the title
|
question: would it possible to update the one in eth-utils instead? |
|
Not sure yet. I opened a similar PR implementing this lib on the web3.py repo and if that's the direction the eth foundation wants me to swim in I will. Until then, I decided it best to leave the cython implementation fully separate. But based on the stuff I've seen in that repo, they tend to choose readability over compute optimizations |
antazoey
reviewed
Dec 9, 2024
antazoey
reviewed
Dec 9, 2024
antazoey
reviewed
Dec 9, 2024
antazoey
approved these changes
Dec 10, 2024
antazoey
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fixes: #
How I did it
How to verify it
Checklist