fix: provider settings RPC was not being used when it was the default #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
changed the title
fubuloubu
previously approved these changes
Feb 7, 2024
mikeshultz
reviewed
Feb 7, 2024
There was a problem hiding this comment.
I get that the public RPC change was "breaking" in that it changed behavior so it may be a bug. But I'm wondering if this is any more correct.
Say that I happen to be running a local anvil/hardhat node that I'm using for unrelated dev purposes. Then I run ape console --network ethereum:mainnet to do otherwork. I wouldn't really want it to connect to my local node just because it was responds to a HEAD request.
antazoey
force-pushed
the
fix/public-rpc-local-interfere
branch
from
39ebfcf to
60ff402
Compare
antazoey
commented
Feb 7, 2024
antazoey
force-pushed
the
fix/public-rpc-local-interfere
branch
from
60ff402 to
17c6120
Compare
antazoey
force-pushed
the
fix/public-rpc-local-interfere
branch
from
17c6120 to
9fe6f24
Compare
antazoey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
In ape-geth, if was given a provdider-settings URI, use that no matter what
Also, when generating config defaults, if something is running on the local, still use that as the default just in case.
Then, finally, if the default is available, use that instead of again checking for random public
fixes: #1917
How I did it
How to verify it
Checklist