Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue where compile_code was creating a file #131

Merged
merged 4 commits into from
Aug 30, 2024
Merged

fix: issue where compile_code was creating a file #131

merged 4 commits into from
Aug 30, 2024

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Aug 29, 2024 •
edited
Loading

What I did

compile_code was not using the temp project, and thus creating a file locally that never got cleaned up.
this pr:

  1. actually uses the temp project (main issue fix)
  2. cleans up file anyways, just in case!
  3. fixes a failing test (not a bug just the setup needed adjusting)

also if you are reviewing this PR, please also review this one: #130 which is important

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@antazoey antazoey changed the title fix: cleanup file fix: issue where compile_code was creating a file Aug 30, 2024
@antazoey antazoey marked this pull request as ready for review August 30, 2024 15:09
@antazoey antazoey mentioned this pull request Aug 30, 2024
Merged
3 tasks
@antazoey antazoey merged commit b01ff21 into ApeWorX:main Aug 30, 2024
11 checks passed
@antazoey antazoey deleted the fix/cleanup branch August 30, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitwise-constructs bitwise-constructs bitwise-constructs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antazoey @bitwise-constructs