Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Gateway Provider and fix Fork Provider [APE-795] #6

Merged
merged 20 commits into from
Sep 26, 2023

Conversation

fubuloubu
Copy link
Member

@fubuloubu fubuloubu commented Apr 4, 2023

What I did

The plugin never really did anything, and Tenderly just added their Web3 Gateway product with a pretty generous free tier, so this seemed like a good way to add basic support for Tenderly

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@NotPeopling2day NotPeopling2day changed the title feat: add gateway provider using new Tenderly Gateway feat: add gateway provider using new Tenderly Gateway [APE-795] Apr 4, 2023
@linear
Copy link

linear bot commented Apr 4, 2023

APE-795 "feat: add gateway provider using new Tenderly Gateway" (ApeWorX/ape-tenderly #6)

What I did

The plugin never really did anything, and Tenderly just added their Web3 Gateway product with a pretty generous free tier, so this seemed like a good way to add basic support for Tenderly

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

ApeWorX/ape-tenderly #6 by fubuloubu on GitHub

via LinearSync

@NotPeopling2day NotPeopling2day force-pushed the feat/gateway-provider branch 2 times, most recently from a7b6d0f to 7c4498a Compare April 21, 2023 00:05
antazoey
antazoey previously approved these changes Apr 21, 2023
ape_tenderly/provider.py Outdated Show resolved Hide resolved
ape_tenderly/provider.py Show resolved Hide resolved
ape_tenderly/provider.py Show resolved Hide resolved
@fubuloubu fubuloubu requested a review from antazoey September 23, 2023 17:07
ape_tenderly/provider.py Outdated Show resolved Hide resolved
@fubuloubu fubuloubu changed the title feat: add gateway provider using new Tenderly Gateway [APE-795] feat: add Gateway Provider and fix Fork Provider [APE-795] Sep 23, 2023
antazoey
antazoey previously approved these changes Sep 25, 2023
Copy link
Member

@antazoey antazoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! I am a bit confused about the exception handling when adding the middleares though.

ape_tenderly/provider.py Outdated Show resolved Hide resolved
@fubuloubu fubuloubu force-pushed the feat/gateway-provider branch from 598f754 to 6404e6b Compare September 25, 2023 17:56
ape_tenderly/client.py Outdated Show resolved Hide resolved
ape_tenderly/client.py Outdated Show resolved Hide resolved
ape_tenderly/provider.py Show resolved Hide resolved
@fubuloubu fubuloubu requested a review from antazoey September 25, 2023 19:33
@fubuloubu fubuloubu force-pushed the feat/gateway-provider branch from 21f5a45 to a6b682c Compare September 25, 2023 19:34
antazoey
antazoey previously approved these changes Sep 25, 2023
Copy link
Member

@antazoey antazoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ape_tenderly/client.py Outdated Show resolved Hide resolved
tests/test_client.py Outdated Show resolved Hide resolved
@fubuloubu
Copy link
Member Author

fubuloubu commented Sep 25, 2023

Note: tests will not function until TENDERLY_PROJECT, TENDERLY_ACCESS_KEY, and TENDERLY_GATEWAY_ACCESS_KEY are added (but verified working locally)

@fubuloubu fubuloubu merged commit 455d68b into main Sep 26, 2023
@fubuloubu fubuloubu deleted the feat/gateway-provider branch September 26, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants