Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pep-625 compliance and type checking performance refactors #18

Merged
merged 1 commit into from
Dec 9, 2024
Merged

feat: pep-625 compliance and type checking performance refactors #18

merged 1 commit into from
Dec 9, 2024

Conversation

bitwise-constructs
Copy link
Contributor

What I did

Fixes: APE-1853
Fixes: APE-1859

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@bitwise-constructs
Copy link
Contributor Author

bitwise-constructs commented Dec 7, 2024 •
edited
Loading

@antazoey this one is a bit more involved because the __init__ improvements weren't in it, so probably needs a thorough peek. is NETWORKS in provider file fine?

@antazoey antazoey merged commit 2703603 into ApeWorX:main Dec 9, 2024
3 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antazoey antazoey antazoey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bitwise-constructs @antazoey