Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle missing contracts folder ID in remappings #147

Merged
merged 9 commits into from
Jun 6, 2024

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Jun 5, 2024

What I did

Helps old weird foundry projects using some git submodule nonsense pointing at changed crap, i donno... anyway, ape-solidity can be smarter and just find whatever damn dependency sources you are looking for.. may even help older ape projects work with 0.8. will see

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

ape_solidity/compiler.py Outdated Show resolved Hide resolved
@antazoey antazoey marked this pull request as ready for review June 6, 2024 17:53
@antazoey antazoey requested a review from fubuloubu June 6, 2024 17:54
fubuloubu
fubuloubu previously approved these changes Jun 6, 2024
@antazoey antazoey enabled auto-merge (squash) June 6, 2024 19:47
@antazoey antazoey merged commit f378390 into ApeWorX:main Jun 6, 2024
13 checks passed
@antazoey antazoey deleted the fix/auto-check-missing-srcs branch June 6, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants