Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: misses from 0.7 updates #129

Closed
wants to merge 1 commit into from
Closed

chore: misses from 0.7 updates #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@ Use the `add_library()` method from the `ape-solidity` compiler class to add the
A typical flow is:

1. Deploy the library.
1. Call `add_library()` using the Solidity compiler plugin, which will also re-compile contracts that need the library.
1. Deploy and use contracts that require the library.
2. Call `add_library()` using the Solidity compiler plugin, which will also re-compile contracts that need the library.
3. Deploy and use contracts that require the library.

For example:

Expand Down
1 change: 0 additions & 1 deletion ape_solidity/compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,6 @@ def get_standard_input_json(
if not list(files_by_solc_version[solc_version]):
continue

logger.debug(f"Compiling using Solidity compiler '{solc_version}'")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already logged as info above or something

cleaned_version = Version(solc_version.base_version)
solc_binary = get_executable(version=cleaned_version)
arguments = {"solc_binary": solc_binary, "solc_version": cleaned_version}
Expand Down
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
"mdformat>=0.7.17", # Auto-formatter for markdown
"mdformat-gfm>=0.3.5", # Needed for formatting GitHub-flavored markdown
"mdformat-frontmatter>=0.4.1", # Needed for frontmatters-style headers in issue templates
"mdformat-pyproject>=0.0.1", # Allows configuring in pyproject.toml
],
"doc": [
"Sphinx>=6.1.3,<7", # Documentation generator
Expand Down