Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: re-enable macos-latest #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: re-enable macos-latest #9

wants to merge 1 commit into from

Conversation

dtdang
Copy link

@dtdang dtdang commented Jun 17, 2024

What I did

fixes: #

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@dtdang dtdang requested a review from johnson2427 June 17, 2024 22:13
johnson2427
johnson2427 approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@johnson2427 johnson2427 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dtdang dtdang enabled auto-merge (squash) June 18, 2024 15:01
@dtdang
Copy link
Author

dtdang commented Jul 1, 2024

Not sure how to disable the macos-12 tests but the PR is ready to merge if we can skip over those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnson2427 johnson2427 johnson2427 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtdang @johnson2427